Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
PacketsSent
is 0 we end up doing zero division when calculating packet loss inpinger.Statistics()
which ends up reporting asNaN
. This can be problematic if one were to take thepinger.Statistics
struct and marshal it into json, which will end up failing altogether due to having a value ofNaN
. Ref: golang/go#3480Running the test I added in this branch without any other code change highlights this problem: