Cleanup exporter metrics #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First round of cleanup based on feedback. |
SuperQ
force-pushed
the
bjk/cleanup
branch
2 times, most recently
from
45b0cbf to
276db73
Compare
* Remove scrape counter, covered by promhttp metrics. * Combine up and error metrics to simplify use. * Remove scrape duration counter, covered by `scrape_duration_seconds`. * Use Const metric for `up` metric. * Remove unecessary mutex. Signed-off-by: Ben Kochie <[email protected]>
|
👍 I think you might be better off failing the scrape on an error, which makes it easier for users. |
|
For now, I think we want to maintain partial results on pgbouncer issues. |
SuperQ
added a commit
that referenced
this pull request
Jul 8, 2020
Counter names have been updated to match Prometheus naming conventions. * `pgbouncer_stats_queries_duration_seconds` -> `pgbouncer_stats_queries_duration_seconds_total` * `pgbouncer_stats_client_wait_seconds` -> `pgbouncer_stats_client_wait_seconds_total` * `pgbouncer_stats_server_in_transaction_seconds` -> `pgbouncer_stats_server_in_transaction_seconds_total` * [CHANGE] Cleanup exporter metrics #33 * [CHANGE] Update counter metric names #35 * [FEATURE] Add support for SHOW LISTS metrics #36 Other: * Update vendoring. * Update Prometheus build orb. Signed-off-by: Ben Kochie <[email protected]>
Merged
uncleDecart
pushed a commit
to uncleDecart/pgbouncer_exporter
that referenced
this pull request
Aug 23, 2020
Counter names have been updated to match Prometheus naming conventions. * `pgbouncer_stats_queries_duration_seconds` -> `pgbouncer_stats_queries_duration_seconds_total` * `pgbouncer_stats_client_wait_seconds` -> `pgbouncer_stats_client_wait_seconds_total` * `pgbouncer_stats_server_in_transaction_seconds` -> `pgbouncer_stats_server_in_transaction_seconds_total` * [CHANGE] Cleanup exporter metrics prometheus-community#33 * [CHANGE] Update counter metric names prometheus-community#35 * [FEATURE] Add support for SHOW LISTS metrics prometheus-community#36 Other: * Update vendoring. * Update Prometheus build orb. Signed-off-by: Ben Kochie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scrape_duration_seconds.upmetric.Signed-off-by: Ben Kochie [email protected]