Make log level configurable via command-line flag #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per other exporters in the Prometheus ecosystem, make log level configurable by leveraging the promlogflag package. Also a small tweak to Client.Get() to identify specific stats endpoint that returns non-200 HTTP status. Signed-off-by: Daniel Swarbrick <[email protected]>
SuperQ
reviewed
Aug 23, 2023
| @@ -47,7 +49,7 @@ const ( | |||
| ) | |||
|
|
|||
| var ( | |||
| logger = promlog.New(&promlog.Config{}) | |||
| logger = log.NewNopLogger() | |||
There was a problem hiding this comment.
Hmm, maybe we should refactor this so we don't have a main package logger var.
SuperQ
approved these changes
Aug 23, 2023
SuperQ
added a commit
that referenced
this pull request
Nov 6, 2024
* [CHANGE] Drop XML statistics v2 support #171 * [CHANGE] Deprecate collection of task stats by default #200 * [CHANGE] Update logging library #212 * [ENHANCEMENT] Add metric `rpz_rewrites` #208 * [BUGFIX] Make log level configurable via command-line flag #182 Signed-off-by: SuperQ <[email protected]>
Merged
SuperQ
added a commit
that referenced
this pull request
Nov 6, 2024
* [CHANGE] Drop XML statistics v2 support #171 * [CHANGE] Deprecate collection of task stats by default #200 * [CHANGE] Update logging library #212 * [ENHANCEMENT] Add metric `rpz_rewrites` #208 * [BUGFIX] Make log level configurable via command-line flag #182 Signed-off-by: SuperQ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per other exporters in the Prometheus ecosystem, make log level configurable by leveraging the promlogflag package.
Also a small tweak to Client.Get() to identify specific stats endpoint that returns non-200 HTTP status.