Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut 0.6.0; Reverted default values for metric types, let's not break compatibility there #101

Merged
merged 1 commit into from
Oct 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
## unreleased

* [FEATURE] add support for all metric types; deprecated --metric-count flag; --*-interval flags set to 0 means no change; added OpenMetrics support.
## 0.6.0 / 2024-10-14

* [CHANGE] (breaking) `--metric-interval` default value is now zero (not 120) #99
* [CHANGE] (breaking) change `out-of-order` to `--remote-out-of-order` for consistency. #101
* [CHANGE] Install command for `avalanche` moved to `cmd/avalanche/` from `cmd/` #97
* [FEATURE] Added `mtypes` binary for metric type calculation against targets #97
* [FEATURE] `--remote-requests-count` value -1 now makes remote-write send requests indefinitely #90
* [FEATURE] add support for all metric types; deprecated --metric-count flag; --*-interval flags set to 0 means no change; added OpenMetrics support #80 #101

## 0.5.0 / 2024-09-15

Expand Down
2 changes: 1 addition & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.4.0
0.6.0
2 changes: 1 addition & 1 deletion cmd/avalanche/avalanche.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ func main() {
tlsClientInsecure := kingpin.Flag("tls-client-insecure", "Skip certificate check on tls connection").Default("false").Bool()
remoteTenantHeader := kingpin.Flag("remote-tenant-header", "Tenant ID to include in remote_write send. The default, is the default tenant header expected by Cortex.").Default("X-Scope-OrgID").String()
// TODO(bwplotka): Make this a non-bool flag (e.g. out-of-order-min-time).
outOfOrder := kingpin.Flag("out-of-order", "Enable out-of-order timestamps in remote write requests").Default("true").Bool()
outOfOrder := kingpin.Flag("remote-out-of-order", "Enable out-of-order timestamps in remote write requests").Default("true").Bool()
bwplotka marked this conversation as resolved.
Show resolved Hide resolved

kingpin.Parse()
if err := cfg.Validate(); err != nil {
Expand Down
9 changes: 5 additions & 4 deletions metrics/serve.go
Original file line number Diff line number Diff line change
Expand Up @@ -99,12 +99,13 @@ func NewConfigFromFlags(flagReg func(name, help string) *kingpin.FlagClause) *Co
cfg := &Config{}
flagReg("metric-count", "Number of gauge metrics to serve. DEPRECATED use --gauge-metric-count instead").Default("0").
IntVar(&cfg.MetricCount)
// 500 in total by default, just a healthy distribution of types.
flagReg("gauge-metric-count", "Number of gauge metrics to serve.").Default("200").
// NOTE: By default avalanche creates 500 gauges, to keep old behaviour. We could break compatibility,
// but it's less surprising to ask users to adjust and add more types themselves.
flagReg("gauge-metric-count", "Number of gauge metrics to serve.").Default("500").
IntVar(&cfg.GaugeMetricCount)
flagReg("counter-metric-count", "Number of counter metrics to serve.").Default("200").
flagReg("counter-metric-count", "Number of counter metrics to serve.").Default("0").
IntVar(&cfg.CounterMetricCount)
flagReg("histogram-metric-count", "Number of explicit (classic) histogram metrics to serve. Use -histogram-metric-bucket-count to control number of buckets. Note that the overall number of series for a single classic histogram metric is equal to 2 (count and sum) + <histogram-metric-bucket-count> + 1 (+Inf bucket).").Default("10").
flagReg("histogram-metric-count", "Number of explicit (classic) histogram metrics to serve. Use -histogram-metric-bucket-count to control number of buckets. Note that the overall number of series for a single classic histogram metric is equal to 2 (count and sum) + <histogram-metric-bucket-count> + 1 (+Inf bucket).").Default("0").
IntVar(&cfg.HistogramMetricCount)
flagReg("histogram-metric-bucket-count", "Number of explicit buckets (classic) histogram metrics, excluding +Inf bucket.").Default("7").
IntVar(&cfg.HistogramBuckets)
Expand Down
Loading