Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to enable Metric Timestamp #45

Merged
merged 2 commits into from
Apr 1, 2022

Conversation

billpieper
Copy link
Contributor

Enable ability to enable metric timestamps

Provides an option that can be enabled to add the timestamp capability to the metrics that are output. Defaults to off (false) -- which is the existing behavior.

https://prometheus.io/docs/instrumenting/exposition_formats/

metric_name [
  "{" label_name "=" `"` label_value `"` { "," label_name "=" `"` label_value `"` } [ "," ] "}"
] value [ timestamp ]

@billpieper billpieper requested a review from a team March 31, 2022 14:23
@phnx47 phnx47 self-assigned this Mar 31, 2022
@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #45 (9fda387) into master (c626536) will decrease coverage by 0.15%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
- Coverage   15.84%   15.68%   -0.16%     
==========================================
  Files           5        5              
  Lines         101      102       +1     
  Branches       22       22              
==========================================
  Hits           16       16              
- Misses         85       86       +1     
Impacted Files Coverage Δ
src/HttpRequestDurationsMiddleware.cs 0.00% <0.00%> (ø)
src/HttpRequestDurationsOptions.cs 54.54% <0.00%> (-2.60%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c626536...9fda387. Read the comment docs.

@phnx47 phnx47 merged commit 301df97 into prom-client-net:master Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants