-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement getters for Reclass.nodes
and Reclass.classes
#88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
f01746d
to
e8eed26
Compare
3fe6c9d
to
21c9e8d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
21c9e8d
to
cf948be
Compare
064a524
to
2eab4a3
Compare
cf948be
to
79bf396
Compare
This comment was marked as outdated.
This comment was marked as outdated.
c827bac
to
178c9f3
Compare
79bf396
to
3111af0
Compare
This comment was marked as outdated.
This comment was marked as outdated.
523cabb
to
f41dfca
Compare
f41dfca
to
0537541
Compare
3111af0
to
5407ea2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
haasad
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
expected_nodes = set([f"n{i}" for i in range(1, 26)])
this could also be written as set comprehension:
expected_nodes = {f"n{i}" for i in range(1, 26)}
😉
This allows Python code to read basic information about the results of the node and classes discovery without having to render the inventory. the new getters return dicts which map the normalized Reclass entity names (with dots for entities in subdirectories) to the file path associated with the entity.
Reported-by: Adrian Haas <[email protected]>
5407ea2
to
2e8cff9
Compare
Benchmark for 12f8127Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows Python code to read basic information about the results of the node and classes discovery without having to render the inventory.
the new getters return dicts which map the normalized Reclass entity names (with dots for entities in subdirectories) to the file path associated with the entity.
Checklist
bug
,enhancement
,documentation
,change
,breaking
,dependency
,internal
as they show up in the changelog