Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically set package version from Git tag #77

Merged
merged 4 commits into from
Jan 11, 2024
Merged

Conversation

simu
Copy link
Member

@simu simu commented Jan 10, 2024

We extract the version from Git with git describe --tags --always --match=v*, and generate a suitable version for Cargo/maturin from the returned value.

Resolves #42

Checklist

  • The PR has a meaningful title. The title will be used to auto generate the changelog
  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency, internal
    as they show up in the changelog

@simu simu added the internal label Jan 10, 2024
@simu simu force-pushed the feat/auto-bump-version branch from c38da97 to 3d1ed10 Compare January 10, 2024 13:39

This comment was marked as outdated.

This comment was marked as outdated.

@simu simu force-pushed the feat/auto-bump-version branch 2 times, most recently from dbfb25f to cb839b0 Compare January 10, 2024 13:51

This comment was marked as outdated.

@simu simu force-pushed the feat/auto-bump-version branch from cb839b0 to b493871 Compare January 10, 2024 13:52

This comment was marked as outdated.

@simu simu force-pushed the feat/auto-bump-version branch from b493871 to 11083a4 Compare January 10, 2024 13:53

This comment was marked as outdated.

This comment was marked as outdated.

@simu simu force-pushed the feat/auto-bump-version branch from 737bb7b to 6d25261 Compare January 10, 2024 14:04

This comment was marked as outdated.

This comment was marked as outdated.

@simu simu force-pushed the feat/auto-bump-version branch from 6d25261 to 415c56c Compare January 10, 2024 14:08

This comment was marked as outdated.

@simu simu force-pushed the feat/auto-bump-version branch 2 times, most recently from bc184c6 to deb40d4 Compare January 10, 2024 14:14

This comment was marked as outdated.

This comment was marked as outdated.

@simu simu changed the title Test package version from Git tag Automatically set package version from Git tag Jan 10, 2024

This comment was marked as outdated.

@simu simu force-pushed the feat/auto-bump-version branch 3 times, most recently from 8723e59 to 50f3ee2 Compare January 10, 2024 14:46

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

@simu simu mentioned this pull request Jan 10, 2024
3 tasks
@simu simu force-pushed the feat/auto-bump-version branch from 50f3ee2 to 531ca91 Compare January 11, 2024 08:18

This comment was marked as outdated.

@simu simu force-pushed the feat/auto-bump-version branch from 531ca91 to 1313514 Compare January 11, 2024 08:28

This comment was marked as outdated.

@simu simu force-pushed the feat/auto-bump-version branch from 1313514 to 1cad68d Compare January 11, 2024 11:02
@simu simu marked this pull request as ready for review January 11, 2024 11:03
@simu simu requested a review from a team January 11, 2024 11:03
Copy link

Benchmark for d8b82d6

Click to view benchmark
Test Base PR %
Reclass::inventory() multi-threaded 1533.8±49.96µs 1559.0±117.80µs +1.64%
Reclass::inventory() single-threaded 3.4±0.03ms 3.4±0.05ms 0.00%

@simu simu merged commit 3253318 into main Jan 11, 2024
18 checks passed
@simu simu deleted the feat/auto-bump-version branch January 11, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement automatic crate/package version updates based on pushed tags
2 participants