Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ref parser to match on unit pattern where applicable #51

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Update ref parser to match on unit pattern where applicable #51

merged 1 commit into from
Oct 13, 2023

Conversation

simu
Copy link
Member

@simu simu commented Oct 12, 2023

These were highlighted by clippy after updating to Rust 1.73.0. See also https://rust-lang.github.io/rust-clippy/master/index.html#/ignored_unit_patterns

Checklist

  • The PR has a meaningful title. The title will be used to auto generate the changelog
  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency, internal
    as they show up in the changelog

@simu simu added the internal label Oct 12, 2023
@simu simu requested a review from a team October 12, 2023 07:56
@simu simu force-pushed the fix/clippy-lints branch from 53c9ff6 to e96fef7 Compare October 12, 2023 08:56
@simu
Update ref parser to match on unit pattern where applicable
77085ea 
These were highlighted by clippy after updating to Rust 1.73.0.
@simu simu force-pushed the fix/clippy-lints branch from e96fef7 to 77085ea Compare October 13, 2023 12:14
@simu simu merged commit 67c1c0c into main Oct 13, 2023
@simu simu deleted the fix/clippy-lints branch October 13, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haasad haasad haasad approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simu @haasad