Allow disabling reclass-rs diagnostic messages for unknown config options #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
simu
force-pushed
the
feat/reclass-from-config
branch
2 times, most recently
from
a811cd0 to
4d7236b
Compare
…ions We introduce a new optional boolean parameter `verbose` which controls whether diagnostic messages for unknown config options are printed for `Config.from_dict()` and `Reclass.from_config_file()`. If Python callers don't provide the new optional parameter, it defaults to `false` which disables the diagnostic messages.
simu
force-pushed
the
feat/controllable-config-loading-verbosity
branch
from
3cdadd5 to
6715520
Compare
haasad
approved these changes
Feb 26, 2024
Benchmark for 3992520Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduce a new optional boolean parameter
verbosewhich controls whether diagnostic messages for unknown config options are printed for the Python classmethodsConfig.from_dict()andReclass.from_config_file().This parameter is passed to
Config::load_from_file()andConfig::set_option(). Since the new parameter isn't optional for either of these methods, this change is breaking for Rust clients that useConfig::load_from_file().If Python callers don't provide the new optional parameter, it defaults to
falsewhich disables the diagnostic messages.Checklist
bug,enhancement,documentation,change,breaking,dependency,internalas they show up in the changelog