Refactor Reclass constructor classmethods
#104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
simu
force-pushed
the
feat/config-from-dict
branch
2 times, most recently
from
27425cd to
74c8a01
Compare
simu
force-pushed
the
feat/reclass-from-config
branch
from
d4497ad to
3f11177
Compare
This comment was marked as outdated.
This comment was marked as outdated.
simu
force-pushed
the
feat/reclass-from-config
branch
from
3f11177 to
a811cd0
Compare
This comment was marked as outdated.
This comment was marked as outdated.
We rename `Reclass.from_config()` to `Reclass.from_config_file()` and introduce a new `Reclass.from_config()` method which creates a `Reclass` instance from a `Config` instance.
simu
force-pushed
the
feat/reclass-from-config
branch
from
a811cd0 to
4d7236b
Compare
Benchmark for d3da62bClick to view benchmark
|
haasad
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change for users that switched to the
Reclass.from_config()constructor classmethod which was introduced in #92.This PR renames the existing
Reclass.from_config()classmethod toReclass.from_config_file()and introduces a new classmethodReclass.from_config()which initializes aReclassinstance from an already initializedConfiginstance.Checklist
bug,enhancement,documentation,change,breaking,dependency,internalas they show up in the changelog