Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable pruning for automated sync of root app #218

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

simu
Copy link
Member

@simu simu commented Dec 30, 2024

This ensures that we'll be able to roll out support for multiple root apps without having to disable auto-sync for the default root app before the roll out, since we already have some configuration that will reassign existing component instances to another root app.

Later, we'll want to keep this setting, so we can move component instances between different root apps without having to manually disable auto-sync for the root apps on all clusters that use the component that's being moved.

Extracted from #216

Checklist

  • The PR has a meaningful title. It will be used to auto-generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

This ensures that we'll be able to roll out support for multiple root
apps without having to disable auto-sync for the default root app before
the roll out, since we already have some configuration that will
reassign existing component instances to another root app.

Later, we'll want to keep this setting, so we can move component
instances between different root apps without having to manually disable
auto-sync for the root apps on all clusters that use the component
that's being moved.
@simu simu added enhancement New feature or request bump:minor labels Dec 30, 2024
Copy link

github-actions bot commented Dec 30, 2024

🚀 This PR has been released as v8.9.0

Triggering workflows Release

🛠️ Auto tagging enabled with label bump:minor

@simu simu marked this pull request as ready for review December 30, 2024 15:20
@simu simu requested a review from a team December 30, 2024 15:20
@simu simu merged commit e8fc70e into master Dec 31, 2024
16 checks passed
@simu simu deleted the feat/no-prune-on-autosync branch December 31, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump:minor enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants