Only discard changes in alias checkouts when catalog compilation called with --force
#1103
+89
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
force-pushed
the
fix/abort-on-dirty-alias-checkout
branch
from
d60e6a5 to
949cb8b
Compare
simu
force-pushed
the
feat/parallel-alias-setup
branch
from
3f0e27a to
0f9b03b
Compare
simu
force-pushed
the
fix/abort-on-dirty-alias-checkout
branch
from
949cb8b to
596d710
Compare
simu
force-pushed
the
feat/parallel-alias-setup
branch
from
0f9b03b to
77abdb0
Compare
simu
force-pushed
the
fix/abort-on-dirty-alias-checkout
branch
2 times, most recently
from
5e67503 to
b236d21
Compare
simu
force-pushed
the
feat/parallel-alias-setup
branch
2 times, most recently
from
46f96a4 to
4d5f0fc
Compare
This makes it easier to write tests that need `Component.register_alias()`.
simu
force-pushed
the
fix/abort-on-dirty-alias-checkout
branch
2 times, most recently
from
1b96a8f to
5ec3a45
Compare
Encapsulate the component alias setup logic in a separate function.
simu
force-pushed
the
fix/abort-on-dirty-alias-checkout
branch
from
5ec3a45 to
6e84c27
Compare
simu
changed the title
--force is given--force
simu
changed the title
--force--force
simu
changed the title
--force--force
bastjan
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that
commodore catalog compiledoesn't silently discard local changes in a component instance worktree (the same as catalog compilation is already aborted when a component worktree with local changes is encountered).Checklist
bug,enhancement,documentation,change,breaking,dependency,internalas they show up in the changelog