Make the backing MultiDependency for Component non-optional
#1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
added
the
internal
This simplifies a lot of the implementation for `Component` and only surfaces in a minor way in `component_compile` where we may need to create a fake `MultiDependency` if we compile a component outside a Git repo.
simu
force-pushed
the
fix/component-dependency-nonoptional
branch
from
5c2830d to
19906ca
Compare
HappyTetrahedron
approved these changes
Feb 14, 2025
This should cover the `ValueError` when `target_dir` and `self._work_dir` are None.
simu
force-pushed
the
fix/component-dependency-nonoptional
branch
from
e6378c5 to
68e698e
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies a lot of the implementation for
Componentand only surfaces in a minor way incomponent_compilewhere we may need to create a fakeMultiDependencyif we compile a component outside a Git repo.Split out from #1101
Checklist
bug,enhancement,documentation,change,breaking,dependency,internalas they show up in the changelog