Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes removeMiddlePoints in LinkModel.ts. #852

Merged
merged 1 commit into from
Jul 11, 2021

Conversation

ELennard
Copy link
Contributor

@ELennard ELennard commented Jun 2, 2021

RemoveMiddlePoints removed the first point from points, while it should not delete the startpoint.

Checklist

  • The code has been run through pretty yarn run pretty
  • The tests pass on CircleCI
  • You have referenced the issue(s) or other PR(s) this fixes/relates-to
  • The PR Template has been filled out (see below)
  • Had a beer/coffee because you are awesome

What?

Fixes the removeMiddlePoints function in the LinkModel.

Why?

The removeMiddlePoints function removes the startpoint of a link. The function should only remove points between start and endpoint.

How?

Updated the function to skip the first point.

Feel good image:

LOL

RemoveMiddlePoints removed the first point from points, while it should not delete the start- and endpoint.
@dylanvorster dylanvorster merged commit bb6e1d5 into projectstorm:master Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants