Fix CI failure on master and bug Cannot read property 'reportedPosition' of null on link.setSourcePort and link.setSourceTarget

[vadimshvetsov]

Checklist

• The code has been run through pretty yarn run pretty
• The tests pass on CircleCI
• You have referenced the issue(s) or other PR(s) this fixes/relates-to
• The PR Template has been filled out (see below)
• Had a beer/coffee because you are awesome

What?

We've got an error Uncaught TypeError: Cannot read property 'reportedPosition' of null at DefaultLinkModel.setSourcePort when we use link.clearPort(port)

Why?

Because we call then link.setSourcePort(null) or link.setTargetPort(null) to remove port from link.

react-diagrams/packages/react-diagrams-core/src/entities/link/LinkModel.ts

Line 156 in d2f0543

this.setSourcePort(null);

react-diagrams/packages/react-diagrams-core/src/entities/link/LinkModel.ts

Line 158 in d2f0543

this.setTargetPort(null);

But this methods doesn't check port existence before using reportPosition property.

react-diagrams/packages/react-diagrams-core/src/entities/link/LinkModel.ts

Line 227 in d2f0543

if (port.reportedPosition) {

react-diagrams/packages/react-diagrams-core/src/entities/link/LinkModel.ts

Line 249 in d2f0543

if (port.reportedPosition) {

How?

At first we need to expect null as input there for type safety. Then we would check port existence before using it's property

Feel good image:

[apatole]

Is this fix now part of any public release? I am also seeing it and just want to see if upgrading to any new version will fix it? Thanks.

[vadimshvetsov]

@apatole at this moment this is not a part of any public release. We are waiting for @dylanvorster capacity for checking this out.

[apatole]

@vadimshvetsov Thank you for the updates.