Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solaraviz kwargs related bugfix #2463

Merged
merged 6 commits into from
Nov 6, 2024
Merged

solaraviz kwargs related bugfix #2463

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ae76eb6
fix for user warning
quaquel Nov 6, 2024
4ed52aa
bugfix
quaquel Nov 6, 2024
c95dc27
requested changes
quaquel Nov 6, 2024
7ee1fd5
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 6, 2024
07bae82
Update test_solara_viz.py
quaquel Nov 6, 2024
0c6e589
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions mesa/visualization/solara_viz.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,8 @@ def ModelController(
playing = solara.use_reactive(False)
running = solara.use_reactive(True)
if model_parameters is None:
model_parameters = solara.use_reactive({})
model_parameters = {}
model_parameters = solara.use_reactive(model_parameters)

async def step():
while playing.value and running.value:
Expand Down Expand Up @@ -307,7 +308,8 @@ def ModelCreator(

"""
if model_parameters is None:
model_parameters = solara.use_reactive({})
model_parameters = {}
model_parameters = solara.use_reactive(model_parameters)

solara.use_effect(
lambda: _check_model_params(model.value.__class__.__init__, fixed_params),
Expand Down Expand Up @@ -345,6 +347,7 @@ def _check_model_params(init_func, model_params):
model_parameters[name].default == inspect.Parameter.empty
and name not in model_params
and name != "self"
and name != "kwargs"
):
raise ValueError(f"Missing required model parameter: {name}")
for name in model_params:
Expand Down
Loading