-
Notifications
You must be signed in to change notification settings - Fork 948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify ModelController #2282
Simplify ModelController #2282
Conversation
6b0efe4
to
47e2721
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea what any of this code does, but I always like simpler!
Performance benchmarks:
|
else: | ||
playing.value = False | ||
|
||
solara.use_thread(step, [playing.value]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to test if this works on Google Colab.
It is indeed simpler, more readable, and hence can be extended by users if they need to fork the component. The only concern is if it works on Google Colab. |
47e2721
to
ad6c2b5
Compare
Confirmed that it works in Google Colab! |
Not the most urgent of things to do, but I was in the mood to play around with this. Overall, should be much simpler now.