Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure ChartModule label is in lowercase and borderColor is defined #37

Merged
merged 1 commit into from
Oct 16, 2023
Merged

fix: Ensure ChartModule label is in lowercase and borderColor is defined #37

merged 1 commit into from
Oct 16, 2023

Conversation

rht
Copy link
Contributor

@rht rht commented Oct 15, 2023 •
edited
Loading

@rht rht mentioned this pull request Oct 16, 2023
Closed
@rht rht changed the title fix: Ensure ChartModule label is in lowercase fix: Ensure ChartModule label is in lowercase and borderColor is defined Oct 16, 2023
tpike3
tpike3 approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@tpike3 tpike3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@tpike3 tpike3 merged commit 5f40113 into main Oct 16, 2023
@rht rht deleted the fix-label branch October 16, 2023 08:47
@rht
Copy link
Contributor Author

rht commented Oct 16, 2023

Needs to do a new bugfix release for this.

@wang-boyu wang-boyu mentioned this pull request Oct 22, 2023
Closed
@wang-boyu wang-boyu mentioned this pull request Nov 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpike3 tpike3 tpike3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@rht @tpike3