Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add github issue templates and workflows #35

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

wang-boyu
Copy link
Member

This PR depends on #28, in which the ruff ignore list is defined in pyproject.toml.

Differences between this workflow and that in Mesa:

  • pytest is disabled here since there isn't any test case
  • no doc requires since there isn't a readthedocs site

Question: should we open the discussion board for this repo, or shall we use Mesa discussion?

@rht
Copy link
Contributor

rht commented Sep 26, 2023

#28 can't be merged because setup.py has imperative steps that can't be ported to pyproject.toml. You should initialize the ruff section of the pyproject.toml here instead.

Question: should we open the discussion board for this repo, or shall we use Mesa discussion?

Mesa discussion is easier, unless there are lots of new questions on the Tornado viz. I usually redirect people to the Solara viz instead.

@wang-boyu wang-boyu force-pushed the github-templates-workflows branch from 46a585c to e29f4fa Compare September 26, 2023 13:48
@wang-boyu wang-boyu force-pushed the github-templates-workflows branch from e29f4fa to 6e5e110 Compare September 26, 2023 13:56
@wang-boyu
Copy link
Member Author

#28 can't be merged because setup.py has imperative steps that can't be ported to pyproject.toml. You should initialize the ruff section of the pyproject.toml here instead.

Not sure whether I understand this correctly, but I added a pyproject.toml file with the ruff section, copied over from Mesa. This might result in merge conflicts in #28 in the future if it's going to be updated.

Mesa discussion is easier, unless there are lots of new questions on the Tornado viz. I usually redirect people to the Solara viz instead.

Have redirected to Mesa discussions in the issue templates.

@wang-boyu wang-boyu marked this pull request as ready for review September 26, 2023 14:01
@wang-boyu
Copy link
Member Author

Should be ready for review now.

@rht rht merged commit 7dc4ced into projectmesa:main Sep 26, 2023
@wang-boyu wang-boyu deleted the github-templates-workflows branch September 26, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants