-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
intro tutorial: Remove unique_id from Agent init #251
Conversation
9b9719b
to
aab7ce0
Compare
aab7ce0
to
fb72b33
Compare
@tpike3 @wang-boyu I have a very specific question: The notebook had Please explain to how it's intended to work :) Edit: I can confirm that HOODNUM is still saved as an attribute for Agents: |
That's right!
I don't think it's really used, but better confirm with @tpike3 for this tutorial. |
For the Neighbourhood, I think I found an elegant solution of using the def __repr__(self):
return f"Neighbourhood {self.HOODNUM}" This was equivalent of the original behavior of assigning I will give @tpike3 a chance to review and otherwise I will merge tonight. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM --- HOODNUM was taken from whoever made the model initially (Corvince?). I think you solution is very elegant.
Thanks! Please don't merge my PRs though, I like to do that myself (in this case I would have liked to squash). An review and approve is really appreciated! |
Remove
unique_id
from the Agent init in the introduction tutorial, since unique_id is now automatically assigned in Mesa 3.0 and Mesa-geo 0.9.Update after the changes in #248.