Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inserting an activity name starting with a decimal number causes activity name to be overwritten #270

Closed
ghost opened this issue Dec 7, 2015 · 4 comments
Closed

Inserting an activity name starting with a decimal number causes activity name to be overwritten #270

ghost opened this issue Dec 7, 2015 · 4 comments
Labels
bug design Design discussions and interesting use cases hamster-applet issue still there in versions < v2 and in v2.91.3

Comments

@ghost
Copy link

ghost commented Dec 7, 2015

Fails on both 1.04 and master branch

Steps to reproduce:

  1. Click Add Earlier Activity
  2. Enter "10.0@ABC" in the activity field
  3. Enter "Hello World" in the description field (any text will do but must be longer then one word)
  4. Click Save

Expected result

  1. The activity and the description should be saved correctly

Actual result:

  1. The activity field has the second and subsequent words from the description field entered in step 3 above
  2. The description is blank
@auipga auipga mentioned this issue Jan 16, 2016
Closed
@ederag ederag added the design Design discussions and interesting use cases label Dec 17, 2018
@ederag ederag added this to the v2.3 milestone Dec 17, 2018
@ederag ederag added the hamster-applet issue still there in versions < v2 and in v2.91.3 label Feb 3, 2019
@ederag
Copy link
Collaborator

ederag commented Feb 3, 2019

Thanks for the detailed report, with steps to reproduce !

This is fixed in current master (tested with 79db77f).
screenshot_20190203_213751

Leaving open with the hamster-applet label (for the 1.04 version)

@ederag ederag closed this as completed Feb 3, 2019
@ederag ederag reopened this Feb 3, 2019
@ederag ederag mentioned this issue Feb 3, 2019
Merged
@ederag ederag removed this from the v2.3 milestone Feb 27, 2019
@pwhipp
Copy link

pwhipp commented Jul 9, 2019

Probably related so noting this here: in my imported hamster.db I have lots of activities that start with an issue number prefixed by #. These are all coming up blank in the display and when exported.

I was able to workaround the issue by replacing the # with a text string in the db.

@pwhipp pwhipp mentioned this issue Jul 9, 2019
Closed
@ederag
Copy link
Collaborator

ederag commented Jul 10, 2019

@pwhipp Thanks for the report, but could you please open a new issue,
because this one has the "hamster-applet" tag
(meaning fixed in current versions).
And the issue you describe is actually quite different (related to # character and affecting the import too).

@ederag
Copy link
Collaborator

ederag commented Aug 14, 2019

Closing, since the main issue is thought to be solved in the development version.
Thanks for contributing to hamster improvement !

@ederag ederag closed this as completed Aug 14, 2019
GeraldJansen added a commit to GeraldJansen/hamster that referenced this issue Dec 23, 2020
@GeraldJansen
Revert to single comma for description barrier
08c3223 
This PR reverts the use of a double comma to indicate the start of the
description, a breaking change introduced in Hamster 3.0, back to the
previous use of a single comma, as discussed in projecthamster#657. Likewise, the
double comma needed before tags, in the case of descriptions containing
the #hash pattern, is also reverted to the use of a single comma.

This change requires two restrictions to the parsing rules. Firstly,
no comma is allowed in the activity name (projecthamster#270). Secondly, tags
may not be separated by a comma when entered on the commandline
(ie. just use `#tag1 #tag2`, not `#tag1, #tag2`).
matthijskooijman pushed a commit to rhertzog/hamster that referenced this issue Apr 29, 2023
@GeraldJansen @matthijskooijman
Revert to single comma for description barrier
b183b0d 
This PR reverts the use of a double comma to indicate the start of the
description, a breaking change introduced in Hamster 3.0, back to the
previous use of a single comma, as discussed in projecthamster#657. Likewise, the
double comma needed before tags, in the case of descriptions containing
the #hash pattern, is also reverted to the use of a single comma.

This change requires two restrictions to the parsing rules. Firstly,
no comma is allowed in the activity name (projecthamster#270). Secondly, tags
may not be separated by a comma when entered on the commandline
(ie. just use `#tag1 #tag2`, not `#tag1, #tag2`).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug design Design discussions and interesting use cases hamster-applet issue still there in versions < v2 and in v2.91.3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@elbenfreund @pwhipp @ederag