Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add headers to REST options #79

Merged
merged 4 commits into from
Jul 7, 2023
Merged

Conversation

nazmigorkem
Copy link
Contributor

Additional headers can be appended with headers option in REST options.

  • It's useful to put REST proxy authentication key.
  • It is also flexible for other header usages.

@TTtie TTtie added this to the 0.2.0 milestone Jul 2, 2023
@TTtie TTtie added type: enhancement New feature or request scope: REST Issues or pull requests related to REST functionality labels Jul 2, 2023
@TTtie TTtie changed the title Headers option is added to REST options feat: add headers to REST options Jul 2, 2023
lib/rest/RequestHandler.js Outdated Show resolved Hide resolved
Copy link
Member

@TTtie TTtie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TTtie TTtie merged commit 1ffb0af into projectdysnomia:dev Jul 7, 2023
TTtie pushed a commit that referenced this pull request Jul 7, 2023
* headers option is added to REST options

* fixed linting

* fixed typing

* changed the order of header assignment
TTtie pushed a commit that referenced this pull request Aug 10, 2023
* headers option is added to REST options

* fixed linting

* fixed typing

* changed the order of header assignment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: REST Issues or pull requests related to REST functionality type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants