feat: voice message support #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TTtie
added
type: enhancement
While currently the docs specify it is a base64 byte array, it might be more worthwhile to give the API consumer a raw string and let them deal with it appropriately. Let alone this is probably a more future-proof variant, as (although very unlikely) the format could change in the future.
TTtie
force-pushed
the
feat/voice-messages
branch
from
75adee9 to
8751701
Compare
TTtie
added a commit
that referenced
this pull request
Apr 20, 2023
* feat: voice message support Ref: discord/discord-api-docs#6082 * keep the waveform as-is While currently the docs specify it is a base64 byte array, it might be more worthwhile to give the API consumer a raw string and let them deal with it appropriately. Let alone this is probably a more future-proof variant, as (although very unlikely) the format could change in the future.
TTtie
added a commit
that referenced
this pull request
May 11, 2023
* feat: voice message support Ref: discord/discord-api-docs#6082 * keep the waveform as-is While currently the docs specify it is a base64 byte array, it might be more worthwhile to give the API consumer a raw string and let them deal with it appropriately. Let alone this is probably a more future-proof variant, as (although very unlikely) the format could change in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: discord/discord-api-docs#6082
Will be marked as ready to review once the relevant API doc PR is merged.