Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Client): add threadID support to editWebhookMessage #28

Merged
merged 4 commits into from
Jan 22, 2023
Merged

feat(Client): add threadID support to editWebhookMessage #28

merged 4 commits into from
Jan 22, 2023

Conversation

Cynosphere
Copy link
Contributor

No description provided.

@TTtie TTtie changed the title fix(Client): add threadID support to editWebhookMessage feat(Client): add threadID support to editWebhookMessage Jan 22, 2023
TTtie
TTtie requested changes Jan 22, 2023
View reviewed changes
Copy link
Member

@TTtie TTtie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few tiny documentation nits:

  • The new option should also be reflected in Message#editWebhook
  • TS definitions aren't updated appropriately to reflect the change - if you aren't able to update them by yourself, let me know and I'll update them.

Otherwise LGTM 🚀

lib/Client.js Outdated Show resolved Hide resolved
@TTtie TTtie added the type: enhancement New feature or request label Jan 22, 2023
@Cynosphere
Copy link
Contributor Author

Cynosphere commented Jan 22, 2023 •
edited
Loading

The new option should also be reflected in Message#editWebhook

The option does not apply here, as threads do not have separate webhooks but rather inherit the channel's webhooks.

EDIT: I misread.

TTtie
TTtie approved these changes Jan 22, 2023
View reviewed changes
Copy link
Member

@TTtie TTtie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@TTtie TTtie merged commit 15ebb0c into projectdysnomia:dev Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TTtie TTtie TTtie approved these changes

Assignees
No one assigned
Labels
type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cynosphere @TTtie