Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add allow/deny options #101

Merged
merged 4 commits into from
Mar 24, 2022
Merged

add allow/deny options #101

merged 4 commits into from
Mar 24, 2022

Conversation

LuitelSamikshya
Copy link
Contributor

@LuitelSamikshya LuitelSamikshya commented Mar 9, 2022 •
edited
Loading

Proposed changes

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@LuitelSamikshya LuitelSamikshya self-assigned this Mar 9, 2022
@LuitelSamikshya LuitelSamikshya added Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Mar 9, 2022
@LuitelSamikshya LuitelSamikshya linked an issue Mar 9, 2022 that may be closed by this pull request
Proxify makes connection to denied IP #100
Closed
Mzack9999
Mzack9999 requested changes Mar 10, 2022
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting to use goflags@dev

go.mod Show resolved Hide resolved
internal/runner/options.go Outdated Show resolved Hide resolved
internal/runner/options.go Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ehsandeep ehsandeep merged commit 02a6f50 into dev Mar 24, 2022
@ehsandeep ehsandeep deleted the issue-100-connection-to-denied-ip branch March 24, 2022 11:10
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@LuitelSamikshya LuitelSamikshya

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proxify makes connection to denied IP
3 participants
@LuitelSamikshya @ehsandeep @Mzack9999