protect the cache from DNS responses that lack an Answer, add .gitign… #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes in this PR:
In testing Nuclei as an embedded library in an AWS lambda (even worse, in a lambda being run in localstack container in docker-compose), with a bit of
fmt.Print*
to print the value ofb
here:I observed that when passing both
https://something
andhttp://something
into the executor with Nuclei configured forBulkSize
greater than 1, the value ofb
occasionally lacked an Answer, which would populate the cache with a bad entry.I honestly don't know if it's due to odd behavior of docker-compose internal DNS, or a go bug or what, but the change in this PR adds some protection for the cache.
Related to this discussion: projectdiscovery/nuclei#2277
Detail:
I added code like:
Then inspected the output to observe there was no
Answer
in theb
passed tod.hm.Set
in some cases. I could not reliably reproduce the problem, but it was frequent enough to warrant the investigation and this PR.