internal/dag: Only process Gateways that match configuration #3380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3380 +/- ##
=======================================
Coverage 75.80% 75.80%
=======================================
Files 98 98
Lines 6543 6556 +13
=======================================
+ Hits 4960 4970 +10
- Misses 1475 1479 +4
+ Partials 108 107 -1
|
|
Moving to 1.14.0 as this is still a draft, @stevesloka please advise if you would like to get this in to 1.13.0! |
stevesloka
requested review from
sunjayBhatia and
youngnick
and removed request for
a team
Contour only cache Gateways that match what's configured for Contour. Updates projectcontour#3351 Signed-off-by: Steve Sloka <[email protected]>
stevesloka
force-pushed
the
processGateway
branch
from
0d070a4 to
f2e51eb
Compare
|
@sunjayBhatia I'd like to get this into 1.13. It was draft since I was stacking PRs. |
skriss
requested changes
Feb 22, 2021
|
Moved back to 1.13, shouldn't be an issue. |
Signed-off-by: Steve Sloka <[email protected]>
sunjayBhatia
approved these changes
Feb 22, 2021
iyacontrol
pushed a commit
to iyacontrol/contour
that referenced
this pull request
Feb 23, 2021
…contour#3380) Only cache Gateways that match what's configured for Contour. Updates projectcontour#3351 Signed-off-by: Steve Sloka <[email protected]> Signed-off-by: iyacontrol <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the map of Gateway objects to only store a single since that's all Contour can be configured to use. Then filters on storing the Gateway that matches its configuration.
Created off of #3370 so that should merge first before this.