Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site/_data: Rename service-apis label to gateway-api #3350

Merged
merged 3 commits into from
Feb 16, 2021

Conversation

stevesloka
Copy link
Member

Updates #3349

Signed-off-by: Steve Sloka [email protected]

@stevesloka stevesloka added this to the 1.13.0 milestone Feb 11, 2021
@stevesloka stevesloka requested a review from a team as a code owner February 11, 2021 20:15
@stevesloka stevesloka requested review from danehans and youngnick and removed request for a team February 11, 2021 20:15
@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #3350 (69f4e62) into main (583264c) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3350      +/-   ##
==========================================
+ Coverage   75.58%   75.63%   +0.04%     
==========================================
  Files          98       98              
  Lines        6348     6348              
==========================================
+ Hits         4798     4801       +3     
+ Misses       1444     1441       -3     
  Partials      106      106              
Impacted Files Coverage Δ
internal/k8s/log.go 69.56% <0.00%> (+6.52%) ⬆️

Copy link
Member

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@stevesloka
Copy link
Member Author

2 failures on the site-proof but can ignore them:

Checking 1108 external links...
- ./_site/docs/v1.11.0/index.html
  *  External link https://www.envoyproxy.io/ failed: 301 Number of redirects hit maximum amount
- ./_site/kindly-running-contour/index.html
Ran on 450 files!


  *  External link https://envoyproxy.io failed: 301 Number of redirects hit maximum amount

HTML-Proofer found 2 failures!
Error: Process completed with exit code 1.

@stevesloka stevesloka merged commit 082f66f into projectcontour:main Feb 16, 2021
@stevesloka stevesloka deleted the renameServiceAPIs branch February 16, 2021 17:06
@stevesloka stevesloka mentioned this pull request Feb 17, 2021
stevesloka added a commit to stevesloka/contour that referenced this pull request Feb 17, 2021
In projectcontour#3350, duplicate labels were added, this resolves that to make sure the labels are unique.

Fixes projectcontour#3368

Signed-off-by: Steve Sloka <[email protected]>
skriss pushed a commit that referenced this pull request Feb 17, 2021
In #3350, duplicate labels were added, this resolves that to make sure the labels are unique.

Fixes #3368

Signed-off-by: Steve Sloka <[email protected]>
iyacontrol pushed a commit to iyacontrol/contour that referenced this pull request Feb 18, 2021
iyacontrol pushed a commit to iyacontrol/contour that referenced this pull request Feb 18, 2021
In projectcontour#3350, duplicate labels were added, this resolves that to make sure the labels are unique.

Fixes projectcontour#3368

Signed-off-by: Steve Sloka <[email protected]>
Signed-off-by: iyacontrol <[email protected]>
iyacontrol pushed a commit to iyacontrol/contour that referenced this pull request Feb 23, 2021
iyacontrol pushed a commit to iyacontrol/contour that referenced this pull request Feb 23, 2021
In projectcontour#3350, duplicate labels were added, this resolves that to make sure the labels are unique.

Fixes projectcontour#3368

Signed-off-by: Steve Sloka <[email protected]>
Signed-off-by: iyacontrol <[email protected]>
iyacontrol pushed a commit to iyacontrol/contour that referenced this pull request Feb 23, 2021
iyacontrol pushed a commit to iyacontrol/contour that referenced this pull request Feb 23, 2021
In projectcontour#3350, duplicate labels were added, this resolves that to make sure the labels are unique.

Fixes projectcontour#3368

Signed-off-by: Steve Sloka <[email protected]>
Signed-off-by: iyacontrol <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants