-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
site/_data: Rename service-apis label to gateway-api #3350
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates projectcontour#3349 Signed-off-by: Steve Sloka <[email protected]>
4 tasks
Codecov Report
@@ Coverage Diff @@
## main #3350 +/- ##
==========================================
+ Coverage 75.58% 75.63% +0.04%
==========================================
Files 98 98
Lines 6348 6348
==========================================
+ Hits 4798 4801 +3
+ Misses 1444 1441 -3
Partials 106 106
|
youngnick
approved these changes
Feb 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
sunjayBhatia
approved these changes
Feb 16, 2021
2 failures on the site-proof but can ignore them:
|
Closed
stevesloka
added a commit
to stevesloka/contour
that referenced
this pull request
Feb 17, 2021
In projectcontour#3350, duplicate labels were added, this resolves that to make sure the labels are unique. Fixes projectcontour#3368 Signed-off-by: Steve Sloka <[email protected]>
Merged
skriss
pushed a commit
that referenced
this pull request
Feb 17, 2021
In #3350, duplicate labels were added, this resolves that to make sure the labels are unique. Fixes #3368 Signed-off-by: Steve Sloka <[email protected]>
iyacontrol
pushed a commit
to iyacontrol/contour
that referenced
this pull request
Feb 18, 2021
…3350) Updates projectcontour#3349 Signed-off-by: Steve Sloka <[email protected]> Signed-off-by: iyacontrol <[email protected]>
iyacontrol
pushed a commit
to iyacontrol/contour
that referenced
this pull request
Feb 18, 2021
In projectcontour#3350, duplicate labels were added, this resolves that to make sure the labels are unique. Fixes projectcontour#3368 Signed-off-by: Steve Sloka <[email protected]> Signed-off-by: iyacontrol <[email protected]>
iyacontrol
pushed a commit
to iyacontrol/contour
that referenced
this pull request
Feb 23, 2021
…3350) Updates projectcontour#3349 Signed-off-by: Steve Sloka <[email protected]> Signed-off-by: iyacontrol <[email protected]>
iyacontrol
pushed a commit
to iyacontrol/contour
that referenced
this pull request
Feb 23, 2021
In projectcontour#3350, duplicate labels were added, this resolves that to make sure the labels are unique. Fixes projectcontour#3368 Signed-off-by: Steve Sloka <[email protected]> Signed-off-by: iyacontrol <[email protected]>
iyacontrol
pushed a commit
to iyacontrol/contour
that referenced
this pull request
Feb 23, 2021
…3350) Updates projectcontour#3349 Signed-off-by: Steve Sloka <[email protected]> Signed-off-by: iyacontrol <[email protected]>
iyacontrol
pushed a commit
to iyacontrol/contour
that referenced
this pull request
Feb 23, 2021
In projectcontour#3350, duplicate labels were added, this resolves that to make sure the labels are unique. Fixes projectcontour#3368 Signed-off-by: Steve Sloka <[email protected]> Signed-off-by: iyacontrol <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #3349
Signed-off-by: Steve Sloka [email protected]