cmd/contour: forcibly terminate the xDS server on shutdown #2797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a regression from projectcontour#2780, where the Contour xDS server would fail to stop because it is waiting for xDS connections to drain (they won't drain). This updates projectcontour#2780. Signed-off-by: James Peach <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2797 +/- ##
=======================================
Coverage 76.77% 76.77%
=======================================
Files 73 73
Lines 5658 5658
=======================================
Hits 4344 4344
Misses 1227 1227
Partials 87 87
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a regression from #2780, where the Contour xDS server would fail
to stop because it is waiting for xDS connections to drain (they won't
drain).
This updates #2780.
Signed-off-by: James Peach [email protected]