Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove modified at update for file creation #425

Merged
merged 1 commit into from
Jan 23, 2024
Merged

fix: remove modified at update for file creation #425

merged 1 commit into from
Jan 23, 2024

Conversation

Yelinz
Copy link
Member

@Yelinz Yelinz commented Jan 22, 2024

No description provided.

@Yelinz Yelinz force-pushed the feat-file-created branch from f52bdea to 09ec2cb Compare January 22, 2024 09:51
@Yelinz Yelinz force-pushed the feat-file-created branch from 09ec2cb to ff96222 Compare January 22, 2024 09:51
@Yelinz Yelinz changed the title feat: add last file created date to document @Yelinz fix: remove modified at update for file creation Jan 22, 2024
@Yelinz Yelinz changed the title @Yelinz fix: remove modified at update for file creation fix: remove modified at update for file creation Jan 22, 2024
@Yelinz Yelinz requested a review from fugal-dy January 22, 2024 16:21
fugal-dy
fugal-dy approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@fugal-dy fugal-dy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fair. The question remains why this was there in the first place..

@Yelinz
Copy link
Member Author

Yelinz commented Jan 23, 2024

Frontend was displaying modified_at, which didnt update when uploading a new file. Which doesnt feel intuitive for users. Changed what is being displaying in the frontend, therefore this isnt needed anymore. Its a cleanup

@Yelinz Yelinz merged commit 86cfbf2 into main Jan 23, 2024
3 checks passed
Yelinz added a commit that referenced this pull request Jan 24, 2024
@Yelinz
chore(release): v3.0.0-beta.5
b9a5c31 
* **tests:** Fix broken tests ([#415](#415)) ([`0bd0cab`](0bd0cab))
* **file:** Add missing create permission check ([#427](#427)) ([`34a57c1`](34a57c1))
* Remove modified at update for file creation ([#425](#425)) ([`86cfbf2`](86cfbf2))
@Yelinz Yelinz mentioned this pull request Jan 24, 2024
Merged
Yelinz added a commit that referenced this pull request Jan 24, 2024
@Yelinz
chore(release): v3.0.0-beta.5
aa4e24a 
* **tests:** Fix broken tests ([#415](#415)) ([`0bd0cab`](0bd0cab))
* **file:** Add missing create permission check ([#427](#427)) ([`34a57c1`](34a57c1))
* Remove modified at update for file creation ([#425](#425)) ([`86cfbf2`](86cfbf2))
@Yelinz Yelinz deleted the feat-file-created branch January 24, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fugal-dy fugal-dy fugal-dy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yelinz @fugal-dy