Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(file): add missing create permission check #427

Merged
merged 1 commit into from
Jan 24, 2024
Merged

fix(file): add missing create permission check #427

merged 1 commit into from
Jan 24, 2024

Conversation

Yelinz
Copy link
Member

@Yelinz Yelinz commented Jan 22, 2024

No description provided.

@Yelinz Yelinz requested a review from fugal-dy January 22, 2024 15:28
fugal-dy
fugal-dy reviewed Jan 23, 2024
View reviewed changes
Copy link
Contributor

@fugal-dy fugal-dy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. took me some time to wrap my head around the generic-api-permissions thingy but looks good.

Still not entirely sure whether the tests other than the patch method do mostly ensure that generic-api-permissions are working or provide an example of how to configure it. But the same would hold for the document permission tests

@Yelinz
Copy link
Member Author

Yelinz commented Jan 23, 2024

Both are just to check if the permission checks are ran, as they have modified the basic viewset methods. Because currently it slipped through that no permissions are evaluated for files.

fugal-dy
fugal-dy approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@fugal-dy fugal-dy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair

@Yelinz Yelinz merged commit 34a57c1 into main Jan 24, 2024
3 checks passed
Yelinz added a commit that referenced this pull request Jan 24, 2024
@Yelinz
chore(release): v3.0.0-beta.5
b9a5c31 
* **tests:** Fix broken tests ([#415](#415)) ([`0bd0cab`](0bd0cab))
* **file:** Add missing create permission check ([#427](#427)) ([`34a57c1`](34a57c1))
* Remove modified at update for file creation ([#425](#425)) ([`86cfbf2`](86cfbf2))
@Yelinz Yelinz mentioned this pull request Jan 24, 2024
Merged
Yelinz added a commit that referenced this pull request Jan 24, 2024
@Yelinz
chore(release): v3.0.0-beta.5
aa4e24a 
* **tests:** Fix broken tests ([#415](#415)) ([`0bd0cab`](0bd0cab))
* **file:** Add missing create permission check ([#427](#427)) ([`34a57c1`](34a57c1))
* Remove modified at update for file creation ([#425](#425)) ([`86cfbf2`](86cfbf2))
@Yelinz Yelinz deleted the fix-ile-perm branch January 24, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fugal-dy fugal-dy fugal-dy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yelinz @fugal-dy