Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calico image push permission denied #619

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

hjiawei
Copy link
Collaborator

@hjiawei hjiawei commented Dec 25, 2024

This change updates calico image push using the correct semaphore secret. It also moves the BUILD_IMAGES environment variables to Makefile targets.

This change updates calico image push using the correct semaphore secret.
It also moves the BUILD_IMAGES environment variables to Makefile targets.
@hjiawei hjiawei force-pushed the use-correct-secrets branch 3 times, most recently from 12e71c1 to b580452 Compare December 25, 2024 07:36
@hjiawei hjiawei marked this pull request as ready for review December 25, 2024 07:51
Copy link
Collaborator

@rene-dekker rene-dekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hjiawei hjiawei merged commit 01a0422 into projectcalico:master Dec 30, 2024
2 checks passed
@hjiawei hjiawei deleted the use-correct-secrets branch December 30, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants