Program routes for VXLAN tunnel IPs assigned from /32 or /128 blocks #9698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
release-note-required
caseydavenport
force-pushed
the
casey-itty-bitty-blocks
branch
from
6231474 to
7e68395
Compare
caseydavenport
force-pushed
the
casey-itty-bitty-blocks
branch
from
111f8f4 to
8ae3baf
Compare
fasaxc
reviewed
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When VXLAN tunnel addresses are assigned from /32 or /128 blocks, the L3 route resolver was masking the REMOTE_WORKLOAD type route with REMOTE_TUNNEL. As a result, the routes weren't being programmed (because we only program routes for REMOTE_TUNNEL if they are borrowed IPs).
This PR modifies the RouteUpdate message to accept multiple types, allowing the L3 route resolver to mark the route with all of the matching types.
The VXLAN data plane now also identifies VXLAN routes that are both REMOTE_TUNNEL and REMOTE_WORKLOAD and programs directly connected routes for them.
This fixes an issue where host <-> pod connectivity was not functional when assigning VXLAN tunnel addresses from /32 or /128 IPAM blocks.
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.