Merge pull request #3485 from projectblacklight/improve-performance-o…

…f-null-objects [#3484] Add missing argument to Hash default proc
projectblacklight · Jan 6, 2025 · bdc3c86 · bdc3c86
2 parents 491962f + b01b1a9
commit bdc3c86
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 1 deletion.
diff --git a/blacklight.gemspec b/blacklight.gemspec
@@ -49,6 +49,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency "rubocop-capybara"
   s.add_development_dependency "rubocop-rspec_rails"
   s.add_development_dependency "rubocop-factory_bot"
+  s.add_development_dependency "rspec-benchmark"
   s.add_development_dependency "i18n-tasks", '~> 1.0'
   s.add_development_dependency "solr_wrapper"
 end
diff --git a/lib/blacklight/solr/response/facets.rb b/lib/blacklight/solr/response/facets.rb
@@ -157,7 +157,7 @@ def merge_facet(name:, value:, hits: nil)
   #   facet data in the response
   def default_aggregations
     @default_aggregations ||= begin
-      h = Hash.new { |key| null_facet_field_object(key) }
+      h = Hash.new { |_hash, key| null_facet_field_object(key) }
       h.with_indifferent_access
     end
   end