Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(htpasswd): add autoreload for htpasswd #2933

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

feat(htpasswd): use dedicated fsnotify reloader for htpasswd file

7b1a4d2
Select commit
Loading
Failed to load commit list.
Open

feat(htpasswd): add autoreload for htpasswd #2933

feat(htpasswd): use dedicated fsnotify reloader for htpasswd file
7b1a4d2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Feb 12, 2025 in 0s

90.95% (-0.12%) compared to 528c2e5

View this Pull Request on Codecov

90.95% (-0.12%) compared to 528c2e5

Details

Codecov Report

Attention: Patch coverage is 71.25749% with 48 lines in your changes missing coverage. Please review.

Project coverage is 90.95%. Comparing base (528c2e5) to head (7b1a4d2).

Files with missing lines Patch % Lines
pkg/api/htpasswd.go 69.67% 30 Missing and 7 partials ⚠️
pkg/api/controller.go 45.00% 8 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2933      +/-   ##
==========================================
- Coverage   91.07%   90.95%   -0.12%     
==========================================
  Files         174      175       +1     
  Lines       32666    32798     +132     
==========================================
+ Hits        29749    29830      +81     
- Misses       2205     2246      +41     
- Partials      712      722      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.