Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing Oci-Subject header pushing index with subject #1589

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

jdolitsky
Copy link
Contributor

@jdolitsky jdolitsky commented Jul 6, 2023

This is an alternative to #1586 but missing the conformance test update

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@andaaron andaaron force-pushed the fix-index-header-no-test branch from dff29e3 to 4f94a67 Compare July 6, 2023 16:04
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #1589 (dff29e3) into main (41b05c6) will increase coverage by 0.02%.
The diff coverage is 72.72%.

❗ Current head dff29e3 differs from pull request most recent head 4f94a67. Consider uploading reports for the commit 4f94a67 to get more accurate results

@@            Coverage Diff             @@
##             main    #1589      +/-   ##
==========================================
+ Coverage   91.29%   91.32%   +0.02%     
==========================================
  Files         117      117              
  Lines       24293    24315      +22     
==========================================
+ Hits        22179    22206      +27     
+ Misses       1576     1568       -8     
- Partials      538      541       +3     
Impacted Files Coverage Δ
pkg/storage/local/local.go 81.76% <72.72%> (-0.07%) ⬇️
pkg/storage/s3/s3.go 82.58% <72.72%> (-0.10%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@andaaron andaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes that can be covered have been covered.

Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha rchincha merged commit f3aa855 into project-zot:main Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants