Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logger and slack webhook, fixes #11 #13

Merged
merged 2 commits into from
Aug 4, 2019

Conversation

dwi2
Copy link
Contributor

@dwi2 dwi2 commented Aug 3, 2019

TODO

We should reorg the app like https://github.com/GoogleCloudPlatform/getting-started-python/tree/master/5-logging

PM me for asking SLACK_WEBHOOK_URL

Copy link

@AsukaCHikaru AsukaCHikaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not too familiar with Python but good I guess

Copy link
Member

@z6wdc z6wdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANKS LGTM

@dwi2 dwi2 merged commit ea69cbf into project-yori:master Aug 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants