feat: recognize syntax of BLOB and CLOB types.

project-tsurugi · Jan 23, 2025 · 66e629a · 66e629a
1 parent 56b890e
commit 66e629a
Show file tree

Hide file tree

Showing 5 changed files with 69 additions and 6 deletions.
diff --git a/include/mizugaki/ast/type/kind.h b/include/mizugaki/ast/type/kind.h
@@ -46,7 +46,7 @@ enum class kind {
     /**
      * @brief character large object type.
      */
-    character_large_object, // FIXME: impl
+    character_large_object,
 
     /**
      * @brief bit string type.
@@ -75,7 +75,7 @@ enum class kind {
     /**
      * @brief binary large object type.
      */
-    binary_large_object, // FIXME: impl
+    binary_large_object,
 
     /**
      * @brief exact numeric type.
@@ -221,7 +221,7 @@ template<> struct type_of<kind, kind::character> : ::takatori::util::meta_type<c
 /// @brief provides implementation type of kind::character_varying.
 template<> struct type_of<kind, kind::character_varying> : ::takatori::util::meta_type<character_string> {};
 
-/// @brief FIXME:  provides implementation type of kind::character_large_object.
+/// @brief provides implementation type of kind::character_large_object.
 template<> struct type_of<kind, kind::character_large_object> : ::takatori::util::meta_type<simple> {};
 
 /// @brief provides implementation type of kind::bit.
@@ -236,7 +236,7 @@ template<> struct type_of<kind, kind::octet> : ::takatori::util::meta_type<octet
 /// @brief provides implementation type of kind::octet_varying.
 template<> struct type_of<kind, kind::octet_varying> : ::takatori::util::meta_type<octet_string> {};
 
-/// @brief FIXME: provides implementation type of kind::binary_large_object.
+/// @brief provides implementation type of kind::binary_large_object.
 template<> struct type_of<kind, kind::binary_large_object> : ::takatori::util::meta_type<simple> {};
 
 /// @brief provides implementation type of kind::numeric.

diff --git a/include/mizugaki/ast/type/simple.h b/include/mizugaki/ast/type/simple.h
@@ -29,6 +29,8 @@ class simple final : public type {
             node_kind_type::double_precision,
             node_kind_type::boolean,
             node_kind_type::date,
+            node_kind_type::binary_large_object,
+            node_kind_type::character_large_object,
     };
 
     /**

diff --git a/src/mizugaki/parser/sql_parser.yy b/src/mizugaki/parser/sql_parser.yy
@@ -625,7 +625,7 @@
 %token NOT "NOT"
 %token NULL_ "NULL"
 %token NUMERIC "NUMERIC"
-// %token <ast::common::chars> OBJECT "OBJECT"
+%token OBJECT "OBJECT"
 %token OF "OF"
 // %token <ast::common::chars> OFF "OFF"
 %token OLD "OLD"
@@ -4088,7 +4088,22 @@ data_type_system
         {
             $$ = driver.node<ast::type::interval>(@$);
         }
-    // FIXME: large object types
+    | BLOB
+        {
+            $$ = driver.node<ast::type::simple>(ast::type::kind::binary_large_object, @$);
+        }
+    | BINARY LARGE OBJECT
+        {
+            $$ = driver.node<ast::type::simple>(ast::type::kind::binary_large_object, @$);
+        }
+    | CLOB
+        {
+            $$ = driver.node<ast::type::simple>(ast::type::kind::character_large_object, @$);
+        }
+    | character_type_name LARGE OBJECT
+        {
+            $$ = driver.node<ast::type::simple>(ast::type::kind::character_large_object, @$);
+        }
     ;
 
 data_type_composite

diff --git a/src/mizugaki/parser/sql_scanner.ll b/src/mizugaki/parser/sql_scanner.ll
@@ -331,6 +331,7 @@ UTF8_CHAR {ASCII}|{UTF8_2}{U}|{UTF8_3}{U}{U}|{UTF8_4}{U}{U}{U}
 "NOT" { return parser_type::make_NOT(location()); }
 "NULL" { return parser_type::make_NULL_(location()); }
 "NUMERIC" { return parser_type::make_NUMERIC(location()); }
+"OBJECT" { return parser_type::make_OBJECT(location()); }
 "OF" { return parser_type::make_OF(location()); }
 "OLD" { return parser_type::make_OLD(location()); }
 "ON" { return parser_type::make_ON(location()); }

diff --git a/test/mizugaki/parser/sql_parser_type_test.cpp b/test/mizugaki/parser/sql_parser_type_test.cpp
@@ -489,6 +489,51 @@ TEST_F(sql_parser_type_test, DISABLED_interval_qualifier) {
     }));
 }
 
+TEST_F(sql_parser_type_test, blob) {
+    auto result = parse("BLOB");
+    ASSERT_TRUE(result) << diagnostics(result);
+
+    EXPECT_EQ(extract(result), (type::simple {
+            type::kind::binary_large_object,
+    }));
+}
+
+TEST_F(sql_parser_type_test, binary_large_object) {
+    auto result = parse("BINARY LARGE OBJECT");
+    ASSERT_TRUE(result) << diagnostics(result);
+
+    EXPECT_EQ(extract(result), (type::simple {
+            type::kind::binary_large_object,
+    }));
+}
+
+TEST_F(sql_parser_type_test, clob) {
+    auto result = parse("CLOB");
+    ASSERT_TRUE(result) << diagnostics(result);
+
+    EXPECT_EQ(extract(result), (type::simple {
+            type::kind::character_large_object,
+    }));
+}
+
+TEST_F(sql_parser_type_test, character_large_object) {
+    auto result = parse("CHARACTER LARGE OBJECT");
+    ASSERT_TRUE(result) << diagnostics(result);
+
+    EXPECT_EQ(extract(result), (type::simple {
+            type::kind::character_large_object,
+    }));
+}
+
+TEST_F(sql_parser_type_test, char_large_object) {
+    auto result = parse("CHAR LARGE OBJECT");
+    ASSERT_TRUE(result) << diagnostics(result);
+
+    EXPECT_EQ(extract(result), (type::simple {
+            type::kind::character_large_object,
+    }));
+}
+
 TEST_F(sql_parser_type_test, row) {
     auto result = parse("ROW (a int)");
     ASSERT_TRUE(result) << diagnostics(result);