Change get_write_count parameter type to const reference

project-tsurugi · Feb 13, 2025 · 0a2870b · 0a2870b
1 parent f45949b
commit 0a2870b
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 6 deletions.
diff --git a/src/jogasaki/api/impl/executable_statement.h b/src/jogasaki/api/impl/executable_statement.h
@@ -74,4 +74,12 @@ inline api::impl::executable_statement& get_impl(api::executable_statement& es)
     return unsafe_downcast<api::impl::executable_statement>(es);
 }
 
+/**
+ * @brief accessor to the impl of api::executable_statement
+ * @return reference to the const impl object
+ */
+inline api::impl::executable_statement const& get_impl(api::executable_statement const& es) {
+    return unsafe_downcast<api::impl::executable_statement const>(es);
+}
+
 } // namespace jogasaki::api::impl
diff --git a/src/jogasaki/api/impl/service.cpp b/src/jogasaki/api/impl/service.cpp
@@ -1412,7 +1412,7 @@ void service::execute_query(
     std::shared_ptr<tateyama::api::server::data_channel> ch{};
     {
         trace_scope_name("acquire_channel");  //NOLINT
-        const auto max_write_count = get_write_count(e);
+        const auto max_write_count = get_write_count(*e);
         if (auto rc = res->acquire_channel(info->name_, ch, max_write_count);
             rc != tateyama::status::ok) {
             auto msg = "creating output channel failed (maybe too many requests)";
@@ -1604,7 +1604,7 @@ void service::execute_dump(
     std::shared_ptr<tateyama::api::server::data_channel> ch{};
     {
         trace_scope_name("acquire_channel");  //NOLINT
-        const auto max_write_count = get_write_count(e);
+        const auto max_write_count = get_write_count(*e);
         if (auto rc = res->acquire_channel(info->name_, ch, max_write_count);
             rc != tateyama::status::ok) {
             auto msg = "creating output channel failed (maybe too many requests)";
@@ -1750,9 +1750,8 @@ jogasaki::api::database* service::database() const noexcept {
     return db_;
 }
 
-std::size_t service::get_write_count(
-    std::unique_ptr<jogasaki::api::executable_statement> const& es) const noexcept {
-    const auto& impl_stmt = get_impl(*es);
+std::size_t service::get_write_count(jogasaki::api::executable_statement const& es) const noexcept {
+    const auto& impl_stmt = get_impl(es);
     const auto partitions = impl_stmt.body()->mirrors()->get_partitions();
     if (VLOG_IS_ON(log_debug)) {
         std::stringstream ss{};

diff --git a/src/jogasaki/api/impl/service.h b/src/jogasaki/api/impl/service.h
@@ -613,7 +613,7 @@ class service {
      * @return count of the write_count
      */
     [[nodiscard]] std::size_t get_write_count(
-        std::unique_ptr<jogasaki::api::executable_statement> const& es) const noexcept;
+        jogasaki::api::executable_statement const& es) const noexcept;
 };
 
 // public for testing purpose