-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow showing of games less than 30 seconds #88
Allow showing of games less than 30 seconds #88
Conversation
Trying to think of text that seems more actionable. Like "Click to show all"? |
Isn't "Show" already an action? How's "Show all replays"? Though all doesn't include corrupted replays. So I don't know if we want to disambiguate that. You could have the situation where it says for example:
And in that situation it may not be clear that the corrupted files will not actually be shown. |
I would like to see it as an obvious button, I'm worried users won't realize that text is interactable |
I intentionally kept the styling minimal since I think you guys would have a much better idea of what you want the button to look like and what kinda aesthetics you're after. |
Yeah I think what Nikki mentioned is why I wanted to add the word "Click". But it's a pretty small thing, I'm content enough pushing it as is, UX-wise. I trust you enough to not have to go through the code too deeply lol |
Changed it to "Click to show all" but I haven't changed the styles, check the updated screenshot. Hopefully it's obvious enough to users but if not feel free to change the styles to something else, Nikki. |
What does it look like after you click the button in the case where you:
|
In both cases, the entire banner is hidden after the user clicks "Click to show all". In case number 2 we probably want to keep the banner to indicate the number of corrupted replays but the text copy would need to change. |
LGTM |
Fixes #78
This PR adds the following:
The setting is stored in the local component state which means the option to filter/show is reset back to the default (which is to filter) whenever the component is unmounted.
Screenshot