Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass consoleNick or broadcaster connect code to comm file when spectating #320

Merged
merged 3 commits into from
Jun 7, 2022

Conversation

NikhilNarayana
Copy link
Member

dolphin will take the name and write to the window to make it easier for streamers to identify which dolphin instance is which.

@NikhilNarayana NikhilNarayana requested a review from vinceau June 6, 2022 06:26
@NikhilNarayana NikhilNarayana force-pushed the feat/write-mirror-console-name branch 2 times, most recently from eac6190 to 58fcfcc Compare June 6, 2022 07:48
@NikhilNarayana NikhilNarayana force-pushed the feat/write-mirror-console-name branch from 58fcfcc to 6ca3604 Compare June 6, 2022 20:47
Copy link
Member

@vinceau vinceau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for the most part. Just some naming issues.

Copy link
Member

@vinceau vinceau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NikhilNarayana NikhilNarayana merged commit 12832d5 into main Jun 7, 2022
@vinceau vinceau deleted the feat/write-mirror-console-name branch February 7, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants