Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dolphin never getting to ready state if offline #314

Merged
merged 3 commits into from
May 25, 2022

Conversation

NikhilNarayana
Copy link
Member

Users should still be able to access Dolphin related features as long as the executable is available.

@NikhilNarayana NikhilNarayana requested a review from vinceau May 22, 2022 02:38
Copy link
Member

@vinceau vinceau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NikhilNarayana NikhilNarayana merged commit 660e827 into main May 25, 2022
@NikhilNarayana NikhilNarayana deleted the no-internet branch May 25, 2022 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants