Add DolphinService #311
Merged
Add DolphinService #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikhilNarayana
approved these changes
May 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a DolphinService for interacting with Dolphin features in the front-end. We also include a mock DolphinService which can simulate the Netplay Dolpin installing state.
We introduce a Dolphin installation state for both netplay and playback such that the Slippi Launcher itself can still be used while the Dolphin installation is happening. This should allow people to spend less time in the loading screen while things get installed, and only the functionality that requires Dolphin will be disabled during the installation state.
Fixes #184