refactor: switch case the error codes and add some new ones #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinceau
requested changes
Feb 27, 2022
Comment on lines
256
to
271
| switch (exitCode) { | ||
| case 0x3: { | ||
| // returned when selecting update in game | ||
| return null; | ||
| } | ||
| case 0xc0000135: | ||
| case 0xc0000409: | ||
| case 0xc000007b: { | ||
| return "Required DLLs for launching Dolphin are missing. Check the Help section in the settings page to fix this issue."; | ||
| } | ||
| case 0xc0000005: { | ||
| return "Install the latest Windows update available and then restart your computer."; | ||
| } | ||
| } | ||
| break; | ||
| } |
There was a problem hiding this comment.
Yeah nah. Move this to a separate function like handleWindowsErrorCode(code: number): string | null then you can have your switch statement in there. Likewise with the linux codes.
There was a problem hiding this comment.
Also while you're at it, move those error handling functions and the handleDolphinExitCode function outside of the useAppListeners hook. We don't really need to define them inside the main hook.
vinceau
reviewed
Feb 27, 2022
src/renderer/lib/utils.ts
Outdated
| return "Install the latest Windows update available and then restart your computer."; | ||
| } | ||
| } | ||
| return null; |
There was a problem hiding this comment.
can we move these return null into the default case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm on the fence about how I rewrote this. maybe nested switch statements are bad design, but it does make it easier to add new error codes.