Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: client side display name validation #256

Merged
merged 16 commits into from
Jan 3, 2022
Merged

Conversation

NikhilNarayana
Copy link
Member

The backend and website include the same validation.

@NikhilNarayana NikhilNarayana force-pushed the feat/display-name-validation branch from 40a6431 to d1b384e Compare December 11, 2021 22:03
Copy link
Member

@vinceau vinceau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding in those extra test cases! Just a few more minor nits and it should be good. :)

vinceau
vinceau previously approved these changes Dec 13, 2021
Copy link
Member

@vinceau vinceau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though the builld seems to be broken. :|

@vinceau vinceau force-pushed the feat/display-name-validation branch from a276e6e to bf096ec Compare January 3, 2022 02:24
@vinceau vinceau merged commit cfdffe7 into main Jan 3, 2022
@vinceau vinceau deleted the feat/display-name-validation branch January 3, 2022 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants