Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for installing GC drivers on app install #210

Merged
merged 5 commits into from
Aug 8, 2021
Merged

Add option for installing GC drivers on app install #210

merged 5 commits into from
Aug 8, 2021

Conversation

vinceau
Copy link
Member

@vinceau vinceau commented Aug 1, 2021 •
edited
Loading

This PR adds a custom installer page for optionally installing GC drivers.

installer screenshot

@vinceau vinceau requested a review from NikhilNarayana August 1, 2021 05:27
NikhilNarayana
NikhilNarayana previously approved these changes Aug 2, 2021
View reviewed changes
Copy link
Member

@NikhilNarayana NikhilNarayana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spent too long trying to figure out why isUpdated wasn't working and finally gave up

@NikhilNarayana NikhilNarayana merged commit fb3d5d9 into main Aug 8, 2021
@NikhilNarayana NikhilNarayana mentioned this pull request Aug 24, 2021
Closed
@vinceau vinceau deleted the feat/installer branch August 24, 2021 02:26
@NikhilNarayana NikhilNarayana mentioned this pull request Aug 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikhilNarayana NikhilNarayana NikhilNarayana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinceau @NikhilNarayana