Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ability to set play button functionality #188

Merged
merged 5 commits into from
Jun 26, 2021
Merged

feat: ability to set play button functionality #188

merged 5 commits into from
Jun 26, 2021

Conversation

NikhilNarayana
Copy link
Member

@NikhilNarayana NikhilNarayana commented Jun 26, 2021 •
edited
Loading

Fixes #171

image

vinceau
vinceau requested changes Jun 26, 2021
View reviewed changes
Copy link
Member

@vinceau vinceau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is pretty good for the most part. I do think the radio option descriptions could be more succinct. I might try think of better copy later.

@NikhilNarayana
Copy link
Member Author

This PR is pretty good for the most part. I do think the radio option descriptions could be more succinct. I might try think of better copy later.

I went hyper succinct, we can discuss other options if you want.

@NikhilNarayana NikhilNarayana merged commit 1bbee79 into main Jun 26, 2021
@NikhilNarayana NikhilNarayana deleted the feat/play-button-alt-functionality branch June 30, 2021 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinceau vinceau vinceau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add support for opening other ISOs easily
2 participants
@NikhilNarayana @vinceau