Fixed jab reset detection in combos #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey mate, thanks for this PR but your build is failing so you probably need to first run |
vinceau
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted by Lunar Melee, jab resets aren't picked up by the combo/conversion computers. There's also some false-detection around mangifying-glass damage.
Jab reset states added to isDamaged should take care of the former, the latter is finnicky.
An alternative solution that would fix both would be to check the hitstun (or defender hitlag) bitflag. Doing so would require replays of at least version 2.0.0, so I've held off for now in case I think of something with better compatibility.