add loader error messages if no usb device is mounted for slippi file write #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loader/source/menu.c
Outdated
| @@ -817,24 +818,63 @@ static void Menu_GameSelection_Redraw(MenuCtx *ctx) | |||
| PrintFormat(DEFAULT_SIZE, (ncfg->Config & (NIN_CFG_SLIPPI_FILE_WRITE)) ? GREEN : RED, MENU_POS_X+340+(22*10), | |||
| gamelist_y, "%-3s", (ncfg->Config & (NIN_CFG_SLIPPI_FILE_WRITE)) ? "ON" : "OFF"); | |||
|
|
|||
| // Warn the user if they're running low on USB disk space | |||
| if ((usb_attached == 1) && (ncfg->Config & (NIN_CFG_SLIPPI_FILE_WRITE))) | |||
| if ((ncfg->UseUSB == 0) && (usb_attached != 1) && (ncfg->Config & (NIN_CFG_SLIPPI_FILE_WRITE))) | |||
There was a problem hiding this comment.
can i get some pictures of what these states look like?
|
not ready for merge, not transitioning from the [wrong format] to [ready] state correctly |
the text clarifies that the notice will not update until slippi nintendont restart
this allows the user to check usb drive readiness for file write without returning to loader or restarting the Wii. also add affirmative usb drive file write ready message. It also fixes a bug where having initially no usb drive for file write inserted and then inserting a valid usb drive and backing out to device selection, then coming back in to game selection would show the file system warning/error.
no one should be using FAT/FAT16, so remove that mention. add mention that exFAT is recommended, due to some hotswap problems with FAT32 drives that are somewhat full already
|
figured it out in f2ade90 (after rebase and force-push) ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently, Slippi Nintendont shuts down the Wii completely if there is no usable file write device. there is no way to know beforehand if the file write device is usable. these messages will help users verify that their usb drive is usable for file write, and diagnose why if not
this change also fixes a small bug in
diskio.cregarding init status