Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seekbar toggle #100

Merged
merged 1 commit into from
Jul 4, 2020
Merged

Add seekbar toggle #100

merged 1 commit into from
Jul 4, 2020

Conversation

NikhilNarayana
Copy link
Member

@NikhilNarayana NikhilNarayana commented Jul 4, 2020

Adds seekbar toggle via GUI (View->Toggle Seekbar) and via command line (-hs flag)

Don't merge, i found a bug

@JLaferri JLaferri merged commit fbe603c into slippi Jul 4, 2020
@JLaferri JLaferri deleted the seekbar-toggle branch July 4, 2020 07:14
@vinceau
Copy link
Member

vinceau commented Jul 4, 2020

@JLaferri In the comment above, @NikhilNarayana mentioned that he found a bug, and to not merge it in. Do you happen to know what the bug was and whether or not it's fixed?

@NikhilNarayana
Copy link
Member Author

I couldn't get replays to play when I used the build produced on that branch (I should've tested before making the PR but I thought it would be fine lol)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants